Enhancements for block face & liquid occlusion & Fixes for water Z-fighting with transparent blocks #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altirix
changed the title
Altirix
changed the title
|
After with addition of #89
After fixes for #866 just noticed i squashed over the commit where i swapped out isfluidexposed to isfluidopaque, can revert back anyway if that is prefered as im not too sure myself anymore as im guessing its probs stylistic or mod compat to go with exposed and java is probs optimising out the invert on the return and inverts on the test anyway and if it doesnt the benefit is probs undetectable anyway. |
Altirix
changed the title
Fences, Walls, Carpets, Powdered snow, probs loads im missing
Altirix
changed the title
IsFluidExposed -> IsFluidOccluded IsSideSolid is used to determine if a side would hide the water texture, should be disabled as this can cause Z fighting when further away
Altirix
force-pushed
the
fix-#858-#859
branch
from
138b3c1 to
c833051
Compare
jellysquid3
approved these changes
Nov 22, 2021
|
Great work, and apologies for the late response here. Changes look OK to me and didn't show issues in testing. |
ElectronicManuel
pushed a commit
to ElectronicManuel/sodium-fabric
that referenced
this pull request
Dec 2, 2021
…h transparent blocks (CaffeineMC#892)
IMS212
pushed a commit
to IMS212/sodium-fabric
that referenced
this pull request
Aug 6, 2024
…h transparent blocks (CaffeineMC#892)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
fixes #858 #859